Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gmake to gmakelegacy #2404

Merged
merged 1 commit into from
Jan 1, 2025

Conversation

nickclark2016
Copy link
Member

What does this PR do?

Renames the gmake exporter to gmakelegacy. Provides an alias from gmake2 to gmake. Follow up PR will handle renaming gmake2 to gmake and deprecating the gmake2 exporter name in favor of gmake.

How does this PR change Premake's behavior?

This will break any existing scripts utilizing gmake currently that do not work with gmake2 (should be a minimal group of users). Users can opt into the old exporter by using gmakelegacy instead.

Anything else we should know?

The name gmakelegacy was derived from both a desire to keep scripts using action:gmake* filters working, while explicitly denoting that the exporter is deprecated.

Did you check all the boxes?

  • Focus on a single fix or feature; remove any unrelated formatting or code changes
  • Add unit tests showing fix or feature works; all tests pass
  • Mention any related issues (put closes #XXXX in comment to auto-close issue when PR is merged)
  • Follow our coding conventions
  • Minimize the number of commits
  • Align documentation to your changes

You can now support Premake on our OpenCollective. Your contributions help us spend more time responding to requests like these!

@nickclark2016 nickclark2016 requested a review from a team December 31, 2024 04:06
website/docs/Custom-Rules.md Show resolved Hide resolved
@nickclark2016 nickclark2016 merged commit eb418ab into premake:master Jan 1, 2025
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants