feat(logging): show collection in errors #643
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prescottprue
reviewed
Mar 9, 2024
| @@ -791,7 +792,7 @@ export function dispatchListenerResponse({ | |||
| ? docData.docChanges() | |||
| : docData.docChanges; | |||
| // Dispatch different actions for doc changes (only update doc(s) by key) | |||
| if (docChanges && docChanges.length < docData.size) { | |||
| if (docChanges && docChanges.length < Math.min(MAX_MULTI_ACTION, docData.size)) { | |||
There was a problem hiding this comment.
Where does this max of 15 come from? We should note this in docs and make it an option if it isn't an amount enforced in firebase
prescottprue
reviewed
Mar 9, 2024
| @@ -247,7 +247,7 @@ export function setListener(firebase, dispatch, queryOpts, successCb, errorCb) { | |||
| !!console && | |||
| typeof console.error === 'function' // eslint-disable-line no-console | |||
| ) { | |||
| console.error('redux-firestore listener error:', err); // eslint-disable-line no-console | |||
| console.error(`redux-firestore listener error for collection "${meta?.collection}":`, err); // eslint-disable-line no-console | |||
prescottprue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should probably be configurable or something, but I made this fork because not
knowing where the issue was coming from was always a headache
Check List
If not relevant to pull request, check off as complete
Relevant Issues