Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a menu-opener featured link in the menu builder #212

Open
dswebsme opened this issue Dec 12, 2021 · 0 comments
Open

Create a menu-opener featured link in the menu builder #212

dswebsme opened this issue Dec 12, 2021 · 0 comments

Comments

@dswebsme
Copy link
Collaborator

dswebsme commented Dec 12, 2021

With this commit we've successfully decoupled the menu-opener from the right-menu.

9f4c200

This allows us to manipulate the placement of the menu-opener via hooks. For example, a child theme could contain:

remove_action( 'emma_after_right_menu_items', 'emma_add_menu_opener_menu_item' );
add_action( 'emma_after_primary_menu_items', 'emma_add_menu_opener_menu_item' );

Unfortunately, there are still some limitations to this approach in that we can still only place the menu-opener in one of the 4 default menu areas (left, right, primary, footer). We could not use this method to add a the menu-opener to a utility-widget area.

Ideally, we should be able to place the menu-opener freely and without code in any menu as a Featured Link in the WordPress menu builder.

This would also allow us to revert these commits to keep our menu areas clean and consistent with the WordPress way:

  • e9e75a5
  • a85d051
  • f9f0c15
  • Similarly, the right-menu could also be restored to it's former state (prior to the menu rework)
@dswebsme dswebsme changed the title Create a menu-opener featured link in the menu muilder Create a menu-opener featured link in the menu builder Dec 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant