feat: remove node hovered state on mouseleave event #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 54e24a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
prevwong
reviewed
Oct 16, 2023
Added mouseleave to default hover event handler, the 'hovered' state gets removed when this is triggered
prevwong
force-pushed
the
feat/remove-hovered-on-mouseleave
branch
from
15d95a5
to
10147bf
Compare
prevwong
force-pushed
the
feat/remove-hovered-on-mouseleave
branch
from
10147bf
to
e6b4883
Compare
prevwong
changed the title
prevwong
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
mouseleaveto default hover event handler, thehoveredstate gets removed when this is triggered.Previously, if you wanted to removed the
hoveredstate, you'd have to add something likeref={(ref: HTMLDivElement) => connectors.select(connectors.hover(ref, ''), '')}to a parent container to deselect/remove the hover state when the mouse pointer clicks/is outside of a node.
Also updated the
useEffectinpackages/core/src/editor/Editor.tsxdue to lint error.