Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export dnd utils #656

Merged
merged 4 commits into from
Jun 19, 2024
Merged

chore: export dnd utils #656

merged 4 commits into from
Jun 19, 2024

Conversation

mateusz-oi
Copy link
Contributor

Hello,

I would like to suggest adding exports for Positioner and createShadow. This enhancement would provide more possibilities for handler customization, as outlined in the Craft.js documentation on overriding default event handlers.

We need this to be able to partially use defaultHandlers and modify the create method, leveraging default methods like Positioner and incorporating effects such as createShadow during drag events.

Thank you for considering this suggestion.

@mateusz-oi mateusz-oi requested a review from prevwong as a code owner June 3, 2024 11:28
Copy link

changeset-bot bot commented Jun 3, 2024

🦋 Changeset detected

Latest commit: 2e24b0a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@craftjs/core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
craftjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 3, 2024 1:05pm

@prevwong prevwong changed the title Patch: More possibilities to customize default event handlers chore: export dnd utils Jun 19, 2024
@prevwong
Copy link
Owner

Thanks! 💯

@prevwong prevwong merged commit 62cb06a into prevwong:main Jun 19, 2024
3 checks passed
@github-actions github-actions bot mentioned this pull request Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants