Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyoribogo
approved these changes
Dec 3, 2023
There was a problem hiding this comment.
쉽게 구현할 수 있는 걸 너무 어렵게 구현한 것 같아요!
There was a problem hiding this comment.
여기에 그냥
const handleNavigate = (path: string) => {
if (pathname === '/review-creation' || pathname === '/review-reply') {
// 모달 라벨 click()
return
}
navigate(path)
}요런 식으로 구현할 수는 없을까요?!
hayamaster
approved these changes
Dec 3, 2023
Comment on lines
+141
to
+157
| <Modal | ||
| modalId="mypage" | ||
| content={`페이지를 벗어나면 지금까지 작성한 내용이 모두 삭제됩니다.\n\n 이동하시겠습니까?`} | ||
| label="이동하기" | ||
| handleClickLabel={() => { | ||
| navigate('/profile') | ||
| }} | ||
| /> | ||
|
|
||
| <Modal | ||
| modalId="mainpage" | ||
| content={`페이지를 벗어나면 지금까지 작성한 내용이 모두 삭제됩니다.\n\n 이동하시겠습니까?`} | ||
| label="이동하기" | ||
| handleClickLabel={() => { | ||
| navigate('/') | ||
| }} | ||
| /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📑 구현
리뷰 응답 페이지, 리뷰 생성 페이지에서 마이페이지 이동, 홈으로 이동할 때 모달을 띄워줍니다!
추가로 리뷰 전송, 리뷰 마감시에도 모달을 띄워놓았습니다.!
chrome-capture-2023-11-3.webm
chrome-capture-2023-11-3.1.webm
내용
🚧 참고 사항
location의 pathname을 의존성에 추가해서 페이지 이동시마다 pathname을 검사합니다.
이렇게 되니깐 매번 헤더가 새로 갱신되어 버리는데 어떻게 이를 막을 수 있을 지 잘 모르겠습니다..
리뷰 생성이나리뷰 응답페이지를 pathname이 바뀔때마다 검사할 필요가 있고 해당 페이지에 따라 상태가 바뀌는데ref를 써서 한번 시도해볼게요!