Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

124 network visuals #151

Merged
merged 30 commits into from
Feb 10, 2024
Merged

124 network visuals #151

merged 30 commits into from
Feb 10, 2024

Conversation

FedericoDM
Copy link
Contributor

@FedericoDM FedericoDM commented Feb 7, 2024

Describe Your Changes

  • Added network template and code (added by @anisfeld )
  • Created new database migration to add the is_network_visible column to games
  • Added new util script for administration
  • Added new function to randomly decide if a game has the network visible or not

Non-Obvious Technical Information

  • @anisfeld note that we are still missing the translations for the text we want to show along the network!
  • Note that the is_network_visible column is set to 'false' by default and is not nullable

Checklist Before Requesting a Review

  • The code runs successfully.

The games table looks like this:

image

And the networks template looks like this:
(with some randomization see below)
Screenshot 2024-02-11 at 12 59 55 AM

@FedericoDM FedericoDM marked this pull request as ready for review February 7, 2024 02:05
@anisfeld
Copy link
Collaborator

anisfeld commented Feb 8, 2024

The PR looks good! Thanks for your work on this!

Before merging, we need to

  • fix an issue with the java script (we shouldn't have the twisty network image you have up there. (@anisfeld)
  • add language that @pepipandi gives me!! (I might ask @FedericoDM to help with this step or might do it myself depending on the timing).

@anisfeld
Copy link
Collaborator

anisfeld commented Feb 9, 2024

I updated the network visualizations @pepipandi we now have two distinct layouts per network types (the new is like a rotation of the previous one.

Screenshot 2024-02-09 at 5 50 36 PM Screenshot 2024-02-09 at 5 50 54 PM Screenshot 2024-02-09 at 5 51 16 PM Screenshot 2024-02-09 at 5 55 34 PM

@FedericoDM
Copy link
Contributor Author

I have added the translations and text into the network.html file @anisfeld:

image

Not sure if you wanted the text on top or at the bottom of the network, but that can be changed

@anisfeld anisfeld merged commit 3a857e9 into main Feb 10, 2024
2 checks passed
@anisfeld anisfeld deleted the 124-network-visuals branch February 10, 2024 17:01
@anisfeld anisfeld mentioned this pull request Feb 10, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants