Skip to content

Commit

Permalink
Remove the unused log::sink module
Browse files Browse the repository at this point in the history
The `LogSink` trait got introduced in 7188fc9 to abstract log sinks
(destinations). A `FileSink` implementation was added in 3ff4fee to
write logs to a file and optional support for the orchestrator was added
in d35bf6e.

It isn't needed anymore since the implementation in da12a96 stopped
relying on `FileSink` or rather `FileLogSinkFactory`.
The `log::filesink` module was then removed in `bfe392e` but `log::sink`
never got cleanup up. I noticed this now because `rustc 1.75.0-beta.1`
detected the unused import: `sink::*` in `src/log/mod.rs:18:9` via the
`unused_imports` lint.

Signed-off-by: Michael Weiss <michael.weiss@atos.net>
  • Loading branch information
primeos-work committed Nov 16, 2023
1 parent 6f511a2 commit 97a62ab
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 24 deletions.
3 changes: 0 additions & 3 deletions src/log/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,4 @@ pub use parser::*;
mod item;
pub use item::*;

mod sink;
pub use sink::*;

mod util;
21 changes: 0 additions & 21 deletions src/log/sink.rs

This file was deleted.

0 comments on commit 97a62ab

Please sign in to comment.