Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict SG projection during SG matching on directly connected route segments #69

Open
adeveloper-wq opened this issue May 21, 2024 · 3 comments · May be fixed by #79
Open

Restrict SG projection during SG matching on directly connected route segments #69

adeveloper-wq opened this issue May 21, 2024 · 3 comments · May be fixed by #79
Assignees

Comments

@adeveloper-wq
Copy link
Member

During our test rides there were occasions where routes where crossing itself (can be caused by round trips). On such intersections currently the SG projection (part of SG matching) may project the SG on two different route segments. This may result in an erroneous matching. The SG should only be projected on continuous route segments.

@adeveloper-wq adeveloper-wq converted this from a draft issue May 21, 2024
@adeveloper-wq
Copy link
Member Author

We discussed it today. We think it's an edge case that doesn't occur very often (based on recorded tracks). We consider the following to be the most robust solution that doesnt affect the previous matching: Split the route at intersections (where the route intersects) into multiple route segments and perform individual SG matching for these segments. This leaves normal tracks without intersections unaffected. For the intersection edge cases, however, we would be protected against projections of SGs onto different route segments. Although it is possible that false negatives could occur at the ends of the individual route segments (if an SG Map goes beyond an end), we still consider this to be the best solution.

@adeveloper-wq
Copy link
Member Author

Implementing the discussed concept is not as trivial as assumed (GeoDjango and Shapely do not have native APIs for the splitting of a Linestring at own intersection points). We will therefore postpone this for the time being and work on other things. The current progress is on the following branch: https://github.com/priobike/priobike-sg-selector/tree/feature/robustness-against-route-intersections

@PhilippMatthes PhilippMatthes moved this from Todo to Backlog in PrioBike Dev Team Project Board May 23, 2024
@PhilippMatthes PhilippMatthes moved this from Backlog to In Progress in PrioBike Dev Team Project Board Jul 15, 2024
@PhilippMatthes PhilippMatthes self-assigned this Jul 15, 2024
@PhilippMatthes
Copy link
Collaborator

PhilippMatthes commented Jul 15, 2024

See #79 for a possible solution and explanation of that solution

@priobike priobike locked and limited conversation to collaborators Jul 15, 2024
@priobike priobike unlocked this conversation Jul 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
2 participants