Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR objective is to clean up and fix the link types (model + value).
This PR initially assumes that we will support
allowText
andvariants
for Link To Media and Generic Link.We are waiting for a final product decision and, of course, this will impact the code if we decide to drop support, as it's the case for Content Relationship.
Model
allowText
should not be defined on Content Relationshipvariants
should be defined for Link To Media.Value
Filled
links have text and variants as they are re-used everywhere to define what a link even coming from a generic link can be.EmptyLinkField
doesn't by default havetext
andvariant
as it's used inContentRelationshipField
text
andvariant
manually when types are used for Rich TextChecklist
Preview
How to QA 1
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩