fix: allow "page" param to properly pass through getall methods #370
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #369
Description
The
dangerouslyGetAll
method (and allgetAll*
methods utilizing it) now uses thepage
param passed in as the starting point for its search results instead of only searching from the first page.This fixes the offset pagination for the client without having to directly create and send out API requests with
fetch()
.Checklist
No existing tests fail as a result of this change.
How to QA 1
Utilize the snippet of code provided in the original issue on the new client.
Changes have not yet been tested on a real Prismic project. The code was read and traced through line by line.
Footnotes
Please use these labels when submitting a review:
⚠️ #issue: Strongly suggest a change.
❓ #ask: Ask a question.
💡 #idea: Suggest an idea.
🎉 #nice: Share a compliment. ↩