Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 19 #204

Merged
merged 2 commits into from
May 30, 2024
Merged

Support React 19 #204

merged 2 commits into from
May 30, 2024

Conversation

levimykel
Copy link
Contributor

Types of changes

  • Add support for React 19 in the library's peer dependencies
  • Chore (a non-breaking change which is related to package maintenance)
  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

Resolves DT-2165

Checklist:

  • My change requires an update to the official documentation.
  • All TSDoc comments are up-to-date and new ones have been added where necessary.
  • All new and existing tests are passing.

Copy link

github-actions bot commented May 30, 2024

size-limit report 📦

Path Size
./dist/index.cjs 8.03 KB (0%)
./dist/index.js 6.05 KB (0%)
./dist/react-server.cjs 7.23 KB (0%)
./dist/react-server.js 5.58 KB (0%)

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.68%. Comparing base (d7f196f) to head (f299127).
Report is 1 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   99.68%   99.68%           
=======================================
  Files          20       20           
  Lines        2569     2569           
  Branches       97       97           
=======================================
  Hits         2561     2561           
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change, and then it should be good to merge!

package.json Outdated Show resolved Hide resolved
@levimykel levimykel self-assigned this May 30, 2024
Copy link
Member

@angeloashmore angeloashmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@levimykel levimykel merged commit 48142ed into master May 30, 2024
1 check passed
@levimykel levimykel deleted the lg/react-19 branch May 30, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants