Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proof of passport to openpassport #188

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

0xturboblitz
Copy link
Contributor

No description provided.

Copy link

vercel bot commented Aug 27, 2024

@0xturboblitz is attempting to deploy a commit to the Privacy and Scaling Explorations Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

@ChialiT ChialiT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xturboblitz the "n"OpenPassport, is it on purpose or?

app/i18n/locales/de/projects/proof-of-passport.json Outdated Show resolved Hide resolved
@0xturboblitz
Copy link
Contributor Author

@0xturboblitz the "n"OpenPassport, is it on purpose or?

Looks like there are line jumps at the beginning and end of OpenPassport's and NFCTap's description, not sure if this is on purpose or we should remove them @kalidiagne

Copy link
Contributor

@thebeyondr thebeyondr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates to the repo! It looks good so far.. If you can remove the "\n" from the copy in locales I'd be happy to approve this 🫡

app/i18n/locales/de/projects/proof-of-passport.json Outdated Show resolved Hide resolved
@0xturboblitz
Copy link
Contributor Author

0xturboblitz commented Aug 29, 2024

Thx @thebeyondr
Just removed the \n in descriptions, not sure what they were here for. Seems to work well without them.

@thebeyondr thebeyondr merged commit 3766e75 into privacy-scaling-explorations:main Aug 29, 2024
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants