Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement ECDH #8
feat: implement ECDH #8
Changes from 10 commits
0d3b065
a6ec58f
5bab3bb
3502e23
3b4cba8
399ced1
d1be79c
0d957d9
120fd63
ed1c46e
f8f046f
4d880f1
25068d4
820bb61
3c26856
9960f44
83878f7
696fb69
6375464
1385f9e
40dab0e
fa95ff4
b4c0027
2a6bd28
5d69406
973e3b7
0ef2486
115004f
116894c
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a bit confusing that this is a
lib
but has amain
function, can this be renamed? Something likegenerate_shared
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here we need to have a main function and a package of
type
bin, don't we @signorecello?Because we do want to compile something: we need the compilation artifact for the node test.
Or is there another way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I mean we shouldn't name libraries according to their use in tests... For the node test we would actually write a
bin
project and compile that oneThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@YashBit saw you resolved this one, but idk what's your opinion
Large diffs are not rendered by default.