Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync GitHub Repo with Internal Codebase (06-24-2024) #10

Merged
merged 2 commits into from
Jun 28, 2024
Merged

Sync GitHub Repo with Internal Codebase (06-24-2024) #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
83d5ae1
Sync GitHub Repo with Internal Codebase (06-24-2024)
yawfrempong-goog Jun 24, 2024
c638015
Update build.yml
yawfrempong-goog Jun 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ jobs:
- name: Build
run: make
- name: Deploy
if: ${{ github.event_name == 'push' && github.ref == 'refs/heads/main' }}
uses: peaceiris/actions-gh-pages@v3
with:
github_token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
20 changes: 14 additions & 6 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,21 +1,29 @@
SHELL = /bin/bash
OUT_DIR ?= out
OUT_DIR_SUB ?= out/dist

.PHONY: all clean validator

all: validator

validator: $(OUT_DIR)/validate-headers.html $(OUT_DIR)/validate-headers.js
validator: $(OUT_DIR)/index.html $(OUT_DIR)/style.css $(OUT_DIR_SUB)/main.js

$(OUT_DIR)/validate-headers.html: header-validation/index.html $(OUT_DIR)
$(OUT_DIR):
@ mkdir -p $@

$(OUT_DIR_SUB):
@ mkdir -p $@

$(OUT_DIR)/index.html: header-validation/index.html $(OUT_DIR)
@ cp $< $@

$(OUT_DIR)/validate-headers.js: header-validation/dist/main.js $(OUT_DIR)
$(OUT_DIR)/style.css: header-validation/style.css $(OUT_DIR)
@ cp $< $@

$(OUT_DIR):
@ mkdir -p $@
$(OUT_DIR_SUB)/main.js: header-validation/dist/main.js $(OUT_DIR_SUB)
@ cp $< $@

header-validation/dist/main.js: header-validation/package.json header-validation/src/*.js
header-validation/dist/main.js: header-validation/package.json header-validation/webpack.config.js header-validation/src/*.js
@ npm ci --prefix ./header-validation
@ npm run build --prefix ./header-validation

Expand Down
31 changes: 15 additions & 16 deletions header-validation/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,24 +21,23 @@ <h1>Attribution Reporting Header Validation</h1>
<fieldset id=header-options>
<legend>Header</legend>
<!--Header Type-->
<p><label><input type=radio name=header value=trigger checked><code>Attribution-Reporting-Register-Trigger</code></label>
<p><label><input type=radio name=header value=source><code>Attribution-Reporting-Register-Source</code></label>
<!--Source Type (only applicable to header type: Attribution-Reporting-Register-Source)-->
<fieldset id=source-type-options>
<legend>Source Type</legend>
<p><label><input type=radio name=source-type value=event checked>event</label>
<p><label><input type=radio name=source-type value=navigation>navigation</label>
</fieldset>
<!-- Registration Type -->
<fieldset id=registration-type-options>
<legend>Registration Type</legend>
<p><label><input type=radio name=registration-type value=app checked>app</label>
<p><label><input type=radio name=registration-type value=web>web</label>
</fieldset>
<p><label><input type=radio name=header value=source checked><code>Attribution-Reporting-Register-Source</code></label>
<p><label><input type=radio name=header value=trigger><code>Attribution-Reporting-Register-Trigger</code></label>
<!--Additional Feature Selection-->
<p><label><input type=checkbox name=feature-ara-parsing-alignment-v1>Measurement Enable ARA Parsing Alignment V1</label>
<p>Flags
<p><label><input type=checkbox name=feature-lookback-window-filter>Measurement Enable Lookback Window Filter</label>
<p><label><input type=checkbox name=feature-trigger-data-matching>Measurement Enable Trigger Data Matching</label>
<p><label><input type=checkbox name=feature-trigger-data-matching checked>Measurement Enable Trigger Data Matching</label>
<p><label><input type=checkbox name=feature-coarse-event-report-destination checked>Measurement Coarse Event Report Destination</label>
<p><label><input type=checkbox name=feature-shared-source-debug-key checked>Measurement Enable Shared Source Debug Key</label>
<p><label><input type=checkbox name=feature-xna>Measurement Enable XNA</label>
<p><label><input type=checkbox name=feature-shared-filter-data-keys checked>Measurement Enable Shared Filter Data Keys (XNA)</label>
<p><label><input type=checkbox name=feature-preinstall-check>Measurement Enable Preinstall Check</label>
<p><label><input type=checkbox name=feature-attribution-scopes>Measurement Enable Attribution Scopes</label>
<p><label><input type=checkbox name=feature-aggregation-coordinator-origin checked>Measurement Aggregation Coordinator Origin</label>
<p><label><input type=checkbox name=feature-source-registration-time-optional-for-agg-reports>Measurement Source Registration Time Optional For Aggregate Reports</label>
<p><label><input type=checkbox name=feature-trigger-context-id>Measurement Enable Trigger Context Id</label>
<p><label><input type=checkbox name=feature-enable-update-trigger-header-limit>Measurement Enable Update Trigger Header Limit</label>
<p><label><input type=checkbox name=feature-enable-reinstall-reattribution>Measurement Enable Reinstall Reattribution</label>
</fieldset>

<!--Output Results-->
Expand Down
Loading
Loading