Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update probe-rs mentions #70

Merged
merged 3 commits into from
Jan 15, 2024
Merged

Update probe-rs mentions #70

merged 3 commits into from
Jan 15, 2024

Conversation

bugadani
Copy link
Contributor

This PR modernizes the displayed command suggestions in hints and settings. I've also fixed a few typos and clarified which setting overrides debuggerExecutable

noppej
noppej approved these changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@noppej noppej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this. I found one more typo, but other than that, I am good with this.

FYI. You need to manually bump the version number to 0.21.3 if you want this PR to push a new version to the VSCode marketplace.

package.json Outdated Show resolved Hide resolved
noppej
noppej requested changes Jan 12, 2024
View reviewed changes
Copy link
Contributor

@noppej noppej left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hold merging this until I can look at why the CI is broken.

Yatekii
Yatekii approved these changes Jan 12, 2024
View reviewed changes
Copy link
Member

@Yatekii Yatekii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@noppej
Copy link
Contributor

noppej commented Jan 15, 2024

@bugadani CI is now fixed. Thanks for helping to cleanup the docs/usability issues!

@bugadani
Copy link
Contributor Author

My pleasure :)

@bugadani bugadani merged commit 5dc1bc8 into probe-rs:master Jan 15, 2024
3 checks passed
@bugadani bugadani deleted the update branch January 15, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noppej noppej noppej approved these changes

@Yatekii Yatekii Yatekii approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bugadani @noppej @Yatekii