Automatically install the probe-rs binaries on request #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
reviewed
May 11, 2024
bugadani
reviewed
May 11, 2024
Yatekii
force-pushed
the
task/automatically-install-probe-rs
branch
10 times, most recently
from
f0dd8af
to
a8b836d
Compare
bugadani
reviewed
May 11, 2024
Yatekii
force-pushed
the
task/automatically-install-probe-rs
branch
7 times, most recently
from
fe8c783
to
3ab01f5
Compare
|
Okay one more thing from me, though that's a bit of a scope creep: The plugin should read the binary's version, compare the major to the plugin's version and offer an update if the plugin is newer than the binary. While this algorithm isn't perfect (as it ignores patch updates), it would avoid incompatibility issues arising from a version mismatch. |
|
This will come in a separate PR. |
bugadani
approved these changes
May 11, 2024
|
Awesomesauce :) |
|
@Yatekii This is going to be awesome for new users. Are you planning on updating the installation instructions also? |
|
Hmm why is this not merging 🤔 |
bugadani
force-pushed
the
task/automatically-install-probe-rs
branch
from
3ab01f5
to
730ffb8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.