fix cmake find package

[NissimBendanan]

No description provided.

[probonopd]

Hi @NissimBendanan. Please don't change excludelist.hhere directly. The "source of truth" lives at https://github.com/AppImageCommunity/pkg2appimage/blob/master/excludelist, so please suggest changes (with use cases/test cases) there. Thanks!

[NissimBendanan]

Hi, tools/linuxdeployqt/excludelist.h is part of git repository of https://github.com/probonopd/linuxdeployqt/tree/master In the generated header of file file, we can read: * This file shall be committed by the developers occassionally, * otherwise systems without access to the internet won't be able to build * fully working versions of linuxdeployqt. In my pull request, I want to add a cmake option to avoid the update of this file using internet. This commit is an attempt to update this file with current excluded files. Please tell if you want that I remove this commit from my pull request. Thanks Nissim From: probonopd ***@***.***> Sent: Sunday, 14 May 2023 16:32 To: probonopd/linuxdeployqt ***@***.***> Cc: Ben Danan, Nissam ***@***.***>; Mention ***@***.***> Subject: Re: [probonopd/linuxdeployqt] fix cmake find package and improve exclude list (PR #577) Hi @NissimBendanan<https://urldefense.com/v3/__https:/github.com/NissimBendanan__;!!GjvTz_vk!Q8WP7zZ_14Q9IJI7T782SkCH_91e1KbqVXEaKbAmYpCG4UvTabhRx0HMb-_FDbckokB-FjhDi5oMxEWk_KZ7fb8$>. Please don't change excludelist.hhere directly. The "source of truth" lives at https://github.com/AppImageCommunity/pkg2appimage/blob/master/excludelist<https://urldefense.com/v3/__https:/github.com/AppImageCommunity/pkg2appimage/blob/master/excludelist__;!!GjvTz_vk!Q8WP7zZ_14Q9IJI7T782SkCH_91e1KbqVXEaKbAmYpCG4UvTabhRx0HMb-_FDbckokB-FjhDi5oMxEWkkdnBaAA$>, so please suggest changes (with use cases/test cases) there. Thanks! — Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https:/github.com/probonopd/linuxdeployqt/pull/577*issuecomment-1546901553__;Iw!!GjvTz_vk!Q8WP7zZ_14Q9IJI7T782SkCH_91e1KbqVXEaKbAmYpCG4UvTabhRx0HMb-_FDbckokB-FjhDi5oMxEWk39Z5cr4$>, or unsubscribe<https://urldefense.com/v3/__https:/github.com/notifications/unsubscribe-auth/A43LCQ532RUDIJQ2VU24LOLXGDNEBANCNFSM6AAAAAAX4T7A6Y__;!!GjvTz_vk!Q8WP7zZ_14Q9IJI7T782SkCH_91e1KbqVXEaKbAmYpCG4UvTabhRx0HMb-_FDbckokB-FjhDi5oMxEWk2RseNYI$>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[NissimBendanan]

Hi,

I removed the commit that was updating excludelist.h
And I updated the PR title accordingly

Thanks
Nissim

[probonopd]

Let's make updating excludelist opt-in rather than the default.
Something like UPGRADE_EXCLUDELIST_ONLINE=1.

[probonopd]

Please change the README accordingly in your branch. (This PR will then automatically contain it.) Thanks!

[NissimBendanan]

Can you please help me and tell me in which part of the README you want this change?