Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Получение link'а кнопки по запросу в зависимости от доступа #59

Merged
merged 7 commits into from
Jul 12, 2024

Conversation

Zimovchik
Copy link
Member

removed adding link field by default and added the needed condition

Изменения

Детали реализации

Check-List

  • Вы проверили свой код перед отправкой запроса?
  • Вы написали тесты к реализованным функциям?
  • Вы не забыли применить форматирование black и isort для Back-End или Prettier для Front-End?
    closes Не отправлять URL для internal кнопок #57

removed adding link field by default and added the needed condition
@Zimovchik Zimovchik self-assigned this Jul 9, 2024
Copy link

github-actions bot commented Jul 9, 2024

💩 Code linting failed, use black and isort to fix it.

Copy link

github-actions bot commented Jul 9, 2024

Code Coverage

Coverage Report
FileStmtsMissCoverMissing
services_backend
   __main__.py440%1–7
   schemas.py8450%6–9
services_backend/models
   base.py13469%19–22
   database.py82396%80–81, 101
services_backend/routes
   button.py1875571%80, 110–143, 159–160, 164, 169, 173, 206, 211, 237, 243, 246, 248, 272, 274, 289–318
   category.py1171984%83, 88–89, 99–132, 146, 178–179
TOTAL4458980% 

Summary

Tests Skipped Failures Errors Time
32 0 💤 0 ❌ 0 🔥 1.658s ⏱️

@Zimovchik Zimovchik changed the title Update button.py Получение link'а кнопки по запросу в зависимости от доступа Jul 9, 2024
Copy link
Member

@grigoriev-semyon grigoriev-semyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

немного не то что надо
надо в целом на любой хендлер возвращающий кнопки если на них не хватает прав(type: blocked) отдавать url: null
таких хендлеров 5 вроде

Copy link

💩 Code linting failed, use black and isort to fix it.

Copy link

💩 Code linting failed, use black and isort to fix it.

@grigoriev-semyon grigoriev-semyon merged commit a30db6c into main Jul 12, 2024
2 checks passed
@grigoriev-semyon grigoriev-semyon deleted the zimovchik branch July 12, 2024 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Не отправлять URL для internal кнопок
2 participants