Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vuetify #153

Merged
merged 14 commits into from
Aug 10, 2023
Merged

Vuetify #153

merged 14 commits into from
Aug 10, 2023

Conversation

dyakovri
Copy link
Member

@dyakovri dyakovri commented Aug 7, 2023

    • implements vuetify, - update dependencies
    • hotfix compilation errors
    • hotfix compilation error
    • small ui configuration chenges
  • Theming

@dyakovri dyakovri temporarily deployed to development-pr-153 August 7, 2023 22:21 — with GitHub Actions Inactive
@dyakovri dyakovri temporarily deployed to development-pr-153 August 8, 2023 20:23 — with GitHub Actions Inactive
@dyakovri dyakovri temporarily deployed to development-pr-153 August 8, 2023 20:28 — with GitHub Actions Inactive
@dyakovri dyakovri temporarily deployed to development-pr-153 August 8, 2023 20:32 — with GitHub Actions Inactive
@dyakovri dyakovri temporarily deployed to development-pr-153 August 8, 2023 21:43 — with GitHub Actions Inactive
@dyakovri dyakovri temporarily deployed to development-pr-153 August 10, 2023 17:47 — with GitHub Actions Inactive
@dyakovri dyakovri marked this pull request as ready for review August 10, 2023 18:21
@dyakovri dyakovri temporarily deployed to development-pr-153 August 10, 2023 18:21 — with GitHub Actions Inactive
physphile
physphile requested changes Aug 10, 2023
View reviewed changes
package.json Outdated
"eslint-plugin-vue": "^9.15.1",
"postcss": "^8.4.24",
"material-design-icons-iconfont": "^6.7.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это не нужно

src/components/IrdomLayout.vue Outdated Show resolved Hide resolved
src/components/IrdomNavbar.vue Outdated Show resolved Hide resolved
src/components/IrdomNavbar.vue Outdated Show resolved Hide resolved
src/components/IrdomNavbar.vue Outdated Show resolved Hide resolved
src/components/IrdomNavbar.vue Outdated Show resolved Hide resolved
src/components/IrdomLayout.vue Outdated
<slot />
</main>
<div style="height: 100%; width: 100%" v-touch="touch">
<v-main style="height: 100%">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Было три строчки — стало 10. v-main не обязательно использовать

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это ты написал, я ничего не менял, кроме инлайн стиля))

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Так и подумал) Но это же не к тебе претензии, а к коду, так что все по-честному

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это менять дико долго, от этого едут все экраны

src/main.ts
import './index.css';
import './variables.css';
import 'vuetify/styles';
import 'material-design-icons-iconfont/dist/material-design-icons.css';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вот этот css весит овердофига. Надо использовать другой способ, описанный в доке:

import { aliases, mdi } from 'vuetify/iconsets/mdi-svg'

export default createVuetify({
  icons: {
    defaultSet: 'mdi',
    aliases,
    sets: {
      mdi,
    },
  },
})

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image Что-то удаление этого пакета все похерело

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

У меня не получилось, там надо передавать иконки через переменные, а у нас они зачастую берутся из АПИ

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Нет, по-моему там просто префикс mdi- должен быть, проверь. И вообще эти префиксы настраиваются вроде бы

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Не работают, я потыкал

src/router/index.ts
@@ -52,7 +52,8 @@ const router = createRouter({
routes,
});

router.beforeEach(to => {
router.beforeEach(async to => {
await new Promise(r => setTimeout(r, 150));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это еще зачем?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Чтобы анимации нажатия кнопок успели проигрываться и создавали ощущение целостного приложения

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Отзывчивость интерфейса > просмотра риппла

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Сейчас интерфейс выглядит прыгающим, как на сайте 90х, а не отзывчивым как в современных мобильных приложениях. Мы делаем скорее второе, чем первое

Copy link
Member Author

@dyakovri dyakovri Aug 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я бы лучше сделал переходы через <transition>, но у меня не вышло это сделать сходу

@dyakovri dyakovri temporarily deployed to development-pr-153 August 10, 2023 20:04 — with GitHub Actions Inactive
@dyakovri dyakovri mentioned this pull request Aug 10, 2023
Closed
2 tasks
@dyakovri dyakovri changed the title implement vuetify 2 Vuetify Aug 10, 2023
@grigoriev-semyon grigoriev-semyon merged commit 452d6bc into main Aug 10, 2023
4 checks passed
@grigoriev-semyon grigoriev-semyon deleted the implement-vuetify-2 branch August 10, 2023 20:46
physphile pushed a commit that referenced this pull request Aug 12, 2023
@Temmmmmo @dyakovri @fizfakovets
Error handlers (#142)
ca5865e 
* Error handlers.

* Linting

* Vuetify (#153)

* Email auth no scopes (#157)

* Fix bottom navigation init select (#158)

* Error handlers.

* Linting

---------

Co-authored-by: Dyakov Roman <ROMAN@DYAKOV.SPACE>
Co-authored-by: Artem Netsvetaev <physphile@vk.com>
This was referenced Aug 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@physphile physphile physphile requested changes

@grigoriev-semyon grigoriev-semyon grigoriev-semyon approved these changes

@Temmmmmo Temmmmmo Awaiting requested review from Temmmmmo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dyakovri @grigoriev-semyon @physphile @fizfakovets