Fix for: Backticks in array of objects 72324 #81
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinrode
requested changes
Jun 3, 2024
Having a manifest with Go template expressions, but where all expressions only use backticks, would lead to the Go template not being executed, since such a manifest was also by coincidence a perfectly valid JSON array that was executed right away. Fixed by always executing the Go template, regardless of whether the input already is valid JSON.
Contrary to what we've first assumed, the recursion after template evaluation is currently required for correctly running the datastore tests. But since parallelRepititions was incorrectly assumed to be never zero, the recursive call to parseAndRunTest would never actually run its tests. This partially reverts commit f2c7937.
lhinderberger
force-pushed
the
backticks-in-array-of-objects-72324
branch
from
8221c91 to
056bf86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit description for details