Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error out when the shell script to be executed cannot be written to disk #45

Open
josegonzalez opened this issue Mar 14, 2024 · 0 comments
Labels

Comments

@josegonzalez
Copy link
Collaborator

If you run out of disk space and fail to write the script, we'll get an error like:

/home/dokku/.basher/bash: line 1: main: command not found

This is because of us not checking the error on the write: https://github.com/progrium/go-basher/blob/master/basher.go#L225

What we should do is attempt to sync the file to disk, and fail if it can't. I believe the write failure should show more context than the current error that appears later in the process (when calling the script).

Refs dokku/dokku#5764

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant