-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added configuring of device mount permissions in udev discovery handler #726 #737
Conversation
project-akri#726 Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
@yujinkim-msft can you add maybe @kate-goldenring as reviewer as she requested/suggested configuring of device mount permissions...I cannot do it so far...maybe we can discuss that I could become "maintainer" too.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Kate Goldenring <kate.goldenring@gmail.com> Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
@kate-goldenring Thanks for the review and feedback. I added test test, your validation suggestion and the defaults for the lint files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One final nit suggestion on the test but LGTM
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
Signed-off-by: Marcel Bindseil <marcelbindseil@gmail.com>
What this PR does / why we need it:
This PR adds configuration options for the device mount permissions in the udev discovery handler.
Corresponding doc PR project-akri/akri-docs#116
If applicable:
cargo fmt
)cargo build
)cargo clippy
)cargo test
)cargo doc
)