Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E3S4 - Outpost of Hell, questionable person shouting 'Fire in the Hole!' #55

Open
Konrad22 opened this issue Dec 17, 2018 · 1 comment

Comments

@Konrad22
Copy link

Konrad22 commented Dec 17, 2018

1.12: It doesn't matter who deploys the barrel, it's always Kyara shouting 'Fire in the Hole!' next turn.
1.14: It doesn't matter who deploys the barrel, it's always Elynia shouting 'Fire in the Hole!' next turn.

@Konrad22 Konrad22 changed the title E3S4_01 - Outpost of Hell, barrel related bugs E3S4 - Outpost of Hell, questionable person shouting 'Fire in the Hole!' Dec 22, 2018
@irydacea
Copy link
Member

It's not gonna be always Kyara or Elynia in either version but it's always going to be one of two units.

This is purely a side-effect of the engine's unit table implementation:

                {RANDOM 1,2}

                [message]
                    side=$random
                    race=human,orc,wolf,goblin,faerie,elf
                    message= _ "Fire in the hole!"
                    scroll=no
                    [show_if]
                        {VARIABLE_BOOLEAN_EQUALS activated_charge_message_used no}
                    [/show_if]
                [/message]

While the side selection for the filter is explicitly randomized above (chooses between both player-controlled sides), the rest of the unit selection is not. Unless you explicitly write code to select a random unit from a set, code like this is just selecting the first unit matched by the filter, which is a deterministic outcome in all cases based on who got inserted into the game's live unit table first. I didn't feel it was an important issue at the time when I first wrote the scenario and had more pressing things to work on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants