Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E3S8D: Hero uses the wrong unit variation for the replay preview in Load Game #79

Open
irydacea opened this issue Jul 20, 2020 · 0 comments
Assignees
Milestone

Comments

@irydacea
Copy link
Member

SPOILERS AHEAD.

Anya shows up using her dead unit type variation in the replay preview for E3S8D in Wesnoth 1.14:

image

This appears to be caused by E3S8B ending with the id=Anya leader unit for side 1 being a dummy version of Anya using her dead variation, instead of the real Anya (who is currently discarded permanently instead):

        [unit]
            {CHARACTER_STATS_ANYA}
            # clobber IS_HERO from the stats macro
            {NO_OVERLAYS_NO_ELLIPSE}
            {INJURED_VARIATION_STATS}
            canrecruit=yes
            side=1
            type=Nightshade Fire
            variation=injured
            x,y=66,28
            facing=se
        [/unit]

Thus at the start of E3S8D, Anya's dead variation is still in the recall list and that seems to be what the replay preview uses instead of her final state in E3S8D. (Likewise, the replay for E3S8B uses her normal variation rather than her final state.)

A simple fix would be to change the final E3S8B cutscene so that Anya gets moved to the recall list and her dead self uses a different id. This shouldn't affect either E3S8C or E3S8D since both clobber her with a fresh unit and discard her data entirely.

@irydacea irydacea added this to the 0.11 milestone Jul 20, 2020
@irydacea irydacea self-assigned this Jul 20, 2020
@irydacea irydacea changed the title E3S8D: Anya is dead in the replay preview in Load Game E3S8D: Hero uses the wrong unit variation for the replay preview in Load Game Jul 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant