This repository has been archived by the owner on Sep 6, 2019. It is now read-only.
updated for PHP warnings (ln 465) and missing js #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm a bit out of my league here. @benbalter, look good? Gray |
| @@ -340,7 +340,7 @@ function enqueue_js() { | |||
|
|
|||
| global $post; | |||
|
|
|||
| $js = ( WP_DEBUG ) ? 'js/js.dev.js' : 'js/js.js'; | |||
| $js = ( WP_DEBUG ) ? 'js/js.dev.js' : 'js/js.dev.js'; | |||
There was a problem hiding this comment.
The ideal approach here would be to minify the javascript, if possible, using something like uglify js.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the $post variable to wp_is_post_revision and wp_is_post_autosave to suppress PHP warnings about lack of parameters.
Replaced js/js.js with js/js.dev.js as there was no other file in the /js directory.