Disallow repeated keys and masks #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| net_keys = {net: (0x0, 0xf) for net in (net0, net1)} | ||
|
|
||
| # Build the routing tables | ||
| with pytest.raises(Exception) as err: |
There was a problem hiding this comment.
Can't you assert the correct exception type here?
There was a problem hiding this comment.
Yeah, you can tell I did some bad TDD here.
|
This LGTM, aside from the exception message and type check in the tests! As mentioned offline and in #153, the issue of N:M nets is going to need to be considered properly in the near future. |
mundya
force-pushed
the
multisource_nets_option_3
branch
from
e7965a9 to
e85c5b8
Compare
| Note: The routing trees provided are assumed to be correct and continuous | ||
| (not missing any hops). If this is not the case, the output is undefined. | ||
| .. warning:: | ||
| An exception will be raised if entries with identical keys and masks |
There was a problem hiding this comment.
What type of exception? (i.e. MultisourceRouteError)
`build_routing_tables` raises an exception if multiple nets with the exact same key and mask would cause packets to become duplicated at any node; this is generally an indication that the underlying net should be being treated as a multisource net. Includes suggestions by @mossblaser.
mundya
force-pushed
the
multisource_nets_option_3
branch
from
e85c5b8 to
c275a18
Compare
|
Bump. |
mossblaser
added a commit
that referenced
this pull request
Nov 2, 2015
Disallow repeated keys and masks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build_routing_tablesraises an exception if multiple nets with the exact same key and mask would cause packets to become duplicated at any node; this is generally an indication that the underlying net should be being treated as a multisource net.This is option (3) from #153.
Clearly this is a somewhat contentious change, for example it will break
nengo_spinnakeras stands.