Add TextOrImage widget that can be used to display an image or text
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kevinaboos
commented
Feb 17, 2024
kevinaboos
commented
- This allows us to use the same DSL widget view for image messages regardless of whether they can be successfully displayed or not. This simplifies caching of widgets both internal and external to a timeline's portallist, which will be implemented in an upcoming PR.
"loading..." text while an image is being fetched, or an error if the image fails to load. * This allows us to use the same DSL widget view for image messages regardless of whether they can be successfully displayed or not. This simplifies caching of widgets both internal and external to a timeline's portallist, which will be implemented in an upcoming PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.