Refactor waveform aligner and add test #766
Conversation
dpw13
force-pushed
the
dev/dwagner-audio-alignment-tests
branch
2 times, most recently
from
a2f695d to
086aa37
Compare
| { | ||
| errorSum += std::abs((newWaveformMips[octave][i + sample] - m_oldWaveformMips[octave][i + sample]) * m_aligmentWeights[octave][i]); | ||
| errorSum += std::abs((newWaveformMips[octave][i + offset] - m_oldWaveformMips[octave][i]) * m_aligmentWeights[octave][i]); |
|
|
||
| // Store mip levels for the next frame. Note that we need to recalculate the mips for the *shifted* | ||
| // waveform, so we can't reuse the previous mips. | ||
| ResampleOctaves(m_oldWaveformMips, newWaveform); |
There was a problem hiding this comment.
Please split the individual changes into separate commits: one for the reformatting, one for each fix and one for the tests. This will make it easier to review and later much easier to see what was fixed where and why, without the need to dig up this PR.
If possible, add the reasoning for each change as mentioned in the PR into the respective commit messages.
dpw13
force-pushed
the
dev/dwagner-audio-alignment-tests
branch
from
086aa37 to
e81fe7f
Compare
|
I split the commit into several pieces that should be much easier to review. I've explained what's changing in each commit. The commit that splits |
dpw13
force-pushed
the
dev/dwagner-audio-alignment-tests
branch
from
d1f46d1 to
c5ecad0
Compare
This PR adds a friend test for WaveformAligner that verifies a few internal implementation details as well as verifying proper alignment for waveforms with supported offsets.
This PR also refactors WaveformAligner for readability and fixes two bugs: