Use lucene query parser for search within user-created browse categories #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marlo-longley
force-pushed
the
browse-category-lucene
branch
2 times, most recently
from
546c9c1
to
dda63b8
Compare
jcoyne
requested changes
Jan 16, 2024
marlo-longley
force-pushed
the
browse-category-lucene
branch
from
dda63b8
to
29aff18
Compare
|
@jcoyne I added more to the search builder test to specify that without a search query, we should not override the default parser. This isn't exactly a feature test, but I think it enhances the coverage and captures the changes. I looked into a feature test but it felt complicated to do the setup necessary to execute a real search. Lmk what you think, thanks for the review. |
marlo-longley
force-pushed
the
browse-category-lucene
branch
from
29aff18
to
7138fda
Compare
|
@marlo-longley yes, but that's just a unit test. It says "we're going to use this parser", but it doesn't demonstrate why we have to use that parser. If you could create a feature test that would be better. |
marlo-longley
force-pushed
the
browse-category-lucene
branch
from
7138fda
to
3028d96
Compare
|
@jcoyne thanks for reviewing -- added feature tests. |
corylown
approved these changes
Jan 19, 2024
jcoyne
approved these changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the downstream issue in sul-dlss/exhibits#2377, and restores this functionality which was broken.