ga similar named exhibit collision fix #3165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
corylown
requested changes
Oct 2, 2024
dnoneill
force-pushed
the
analytics-bug
branch
2 times, most recently
from
5cd8ba8
to
d4fc8df
Compare
dnoneill
commented
Oct 2, 2024
| @@ -37,8 +37,8 @@ def dimension_filter(path) | |||
| filter: Google::Analytics::Data::V1beta::Filter.new( | |||
| field_name: 'pagePath', | |||
| string_filter: Google::Analytics::Data::V1beta::Filter::StringFilter.new( | |||
| match_type: :BEGINS_WITH, | |||
| value: path.to_s | |||
| match_type: :PARTIAL_REGEXP, | |||
There was a problem hiding this comment.
FULL_REGEXP works for data and martin-wong as well. Went back and forth about this and decided partial would probably be safer.
dnoneill
force-pushed
the
analytics-bug
branch
from
d4fc8df
to
a703643
Compare
corylown
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes sul-dlss/exhibits#2592