Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add cell-centric discrete spaces (experimental) #1994
Add cell-centric discrete spaces (experimental) #1994
Changes from 33 commits
dd54f21
7b58d8e
aef4a8b
3240a2b
d3df44e
c80a0bd
93d7db5
be7b843
bd788ec
cb0ef18
94f06b1
be6c1af
875d0ed
e4d121d
5769a05
82a64d9
5fdc787
152995c
c524034
972ecc4
a656d93
8df9276
f4a1089
1ebcf06
d362bae
c7d82d0
b2842c0
740f003
2d8fcb5
99ff668
565ae0a
ab87b70
ab13bbc
8f2e3dd
ac8ff31
aa03962
9b28f9d
bbca3ac
fe5a93f
2c80330
c79aaf0
8384cf1
253531c
ebdee8e
bb2fc52
b3efdee
8c7ad05
819e903
0f49dc7
da94fb1
b210686
c35591c
065e5ea
1bfa009
6b1c454
e0d5673
cf789f2
50666c1
e520d3c
85251f0
3a247cb
86127f2
fb19879
5ea5d35
b7ac86c
76ca4a5
45e3e9f
3d8cdfd
ce8ca0b
18bd2a3
62c844e
adff7aa
7d5e6b0
b32af9f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
vision
makes more sense for the usage of the variableradius
, thanradius
itself here. But this is a minor concern.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, I prefer
radius
as it is the same as in the current implementation of spaces.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for agreeing to #1953 (comment) & to be as intuitive as NetLogo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once we added a CellAgent, adding a dedicated move method was a small step. Random walks are now just a one-liner as well.