Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make example import absolute #2402

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Conversation

quaquel
Copy link
Member

@quaquel quaquel commented Oct 23, 2024

As discussed in #2381, the current relative imports with the examples create a problem. This at least makes things run again by using absolute imports.

Copy link

Performance benchmarks:

Model Size Init time [95% CI] Run time [95% CI]
BoltzmannWealth small 🟢 -6.7% [-7.7%, -5.7%] 🔵 -0.2% [-0.3%, +0.0%]
BoltzmannWealth large 🔵 -0.3% [-0.7%, +0.2%] 🔵 -1.4% [-2.4%, -0.4%]
Schelling small 🔵 -1.1% [-1.6%, -0.7%] 🔵 -0.1% [-0.5%, +0.2%]
Schelling large 🔵 -1.8% [-2.8%, -0.7%] 🟢 -9.9% [-11.6%, -8.1%]
WolfSheep small 🔵 -2.6% [-2.9%, -2.3%] 🔵 -0.3% [-0.6%, -0.1%]
WolfSheep large 🔵 -3.6% [-4.4%, -2.7%] 🟢 -11.7% [-12.9%, -10.6%]
BoidFlockers small 🔵 -1.4% [-2.0%, -0.7%] 🔵 -0.3% [-0.8%, +0.2%]
BoidFlockers large 🔵 -0.3% [-1.0%, +0.2%] 🔵 -0.4% [-1.2%, +0.3%]

Copy link
Contributor

@Corvince Corvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for quickly doing this

@quaquel quaquel merged commit d7171c8 into projectmesa:main Oct 23, 2024
10 of 12 checks passed
@quaquel quaquel deleted the absolute_imports branch October 23, 2024 15:47
@EwoutH
Copy link
Member

EwoutH commented Oct 23, 2024

Awesome, let's validate that this works in all our required cases and I will get a new pre-release out tonight.

@EwoutH EwoutH added the example Changes the examples or adds to them. label Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
example Changes the examples or adds to them.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants