-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and restructure EpsteinCivilViolence and PdGrid examples #2408
Conversation
Performance benchmarks:
|
The code reorganization etc. looks fine from my end, so I'll approve the PR on that ground.
Luckily for you, I wasted an entire morning on this for my teaching version of this model on this question: swap out OrthogonalMooreGrid for OrthogonalVonNeumann grid. There are a few more things I would like to do with this example (but those can wait for a separate PR).
I plan to do a pr on this soon based on an mesa 3.0 updated version of my teaching version. It might be nice to include the activation order as a user input in the gui version. It would not be strange if activation order matters a lot in this model. |
Thanks for the swift review!
Huh, that's indeed interesting. Tell me how that went tomorrow!
Yeah definitely play with it (or I can show it tomorrow). Kind of strange! (but also haven't gave it proper brain cycles, those are scares this week) I will leave this PR open for a bit for others to take a look at it, we can merge tomorrow. |
fc0fd2e
to
705e23c
Compare
- Flatten structure - Update the viz and add new discrete grid portrayal - Remove unneeded viz - Add to init
- Flatten structure - Update the viz and add new discrete grid portrayal - Remove unneeded viz - Add to init
705e23c
to
495e4e2
Compare
@quaquel merged, go ahead and follow up with changing the OrthogonalMooreGrid to OrthogonalVonNeumann. If you figured out why that mattered, would be very curious to hear that! |
@quaquel so we don't forget it, should I create an issue for changing the OrthogonalMooreGrid to OrthogonalVonNeumann? |
Yes |
Cleanup and restructure the EpsteinCivilViolence and PdGrid advanced example models. This PR is similar to what was done in the basic examples in #2365.
It draws the discrete spaces as was supported in #2386 and updates the imports to be absolute, similar to #2402.
EpsteinCivilViolence and PdGrid now:
agents.py
file.A few things to note: