-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include main examples readme in docs #2448
Conversation
Performance benchmarks:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really awesome, this is so helpful for the Examples page, especially with the links. A really powerful experience!
I agree. It partly depends on the theme that is used as specified in conf.py. Mesa uses the pydata theme. This is a 3 column layout: https://github.com/pydata/pydata-sphinx-theme. It would not surprise me if there are inconsistencies in how this theme is currently used in the mesa docs. |
So I had a closer look at this. It seems that the left-hand column (Section navigation) is filled based on the presence or absence of a A simple solution, therefore seems to be to divide up the docs a bit more into sections. An obvious brake down would be Overview, Getting Started (with tutorials, examples, migration guide, mesa packages, and best practices), and API docs. This would clear up the top row which is now overcrowded, and make the left hand side of the page more useful. @EwoutH, let me know what you thinks. This is a five-minute PR. |
That might indeed work better than the current setup and give a clean UI. If it’s a five minute PR, could you make it as draft so we can compare? |
This replaces the examples landing page on RTD with one directly based on the README.md file in the examples folder.
To make this work, I had to slightly change the links in the example headers. They don't work anymore on GitHub, but do work on RTD. I think this is a worthwhile tradeoff. If you read the readme on github, you have the file explorere at the top of the page anyway. I tested six or so versions of the links but none worked for both.
I updated the readme to reflect its use on RTD and fixes a broken link.