From 1716aaf03ef040d969638a1e015aa178a6ce79ef Mon Sep 17 00:00:00 2001
From: Simon Gerber <simon.gerber@vshn.ch>
Date: Fri, 25 Aug 2023 10:52:39 +0200
Subject: [PATCH] Remove default CPU limits for CSI driver containers

Some of the work performed by the CSI drivers is very bursty (e.g.
decrypting LUKS volumes), and took much longer than expected with the
fairly aggressive CPU limits that were configured.

This commit completely removes the CPU limits, since they're not really
necessary for a CSI driver.
---
 class/defaults.yml                                   | 12 ------------
 .../csi-cloudscale/10_deployments.yaml               |  9 ---------
 2 files changed, 21 deletions(-)

diff --git a/class/defaults.yml b/class/defaults.yml
index 89f2b7c..93733bd 100644
--- a/class/defaults.yml
+++ b/class/defaults.yml
@@ -15,36 +15,24 @@ parameters:
           requests:
             cpu: 20m
             memory: 32Mi
-          limits:
-            cpu: 100m
         csi-attacher:
           requests:
             cpu: 20m
             memory: 32Mi
-          limits:
-            cpu: 100m
         csi-resizer:
           requests:
             cpu: 20m
             memory: 32Mi
-          limits:
-            cpu: 100m
         csi-cloudscale-plugin:
           requests:
             cpu: 20m
             memory: 32Mi
-          limits:
-            cpu: 100m
       csi_driver:
         csi-node-driver-registrar:
           requests:
             cpu: 20m
             memory: 32Mi
-          limits:
-            cpu: 100m
         csi-cloudscale-plugin:
           requests:
             cpu: 20m
             memory: 32Mi
-          limits:
-            cpu: 100m
diff --git a/tests/golden/defaults/csi-cloudscale/csi-cloudscale/10_deployments.yaml b/tests/golden/defaults/csi-cloudscale/csi-cloudscale/10_deployments.yaml
index 7e36c41..c82adc8 100644
--- a/tests/golden/defaults/csi-cloudscale/csi-cloudscale/10_deployments.yaml
+++ b/tests/golden/defaults/csi-cloudscale/csi-cloudscale/10_deployments.yaml
@@ -50,8 +50,6 @@ spec:
                   - rm -rf /registration/csi.cloudscale.ch /registration/csi.cloudscale.ch-reg.sock
           name: csi-node-driver-registrar
           resources:
-            limits:
-              cpu: 100m
             requests:
               memory: 32Mi
           volumeMounts:
@@ -152,8 +150,6 @@ spec:
           imagePullPolicy: IfNotPresent
           name: csi-provisioner
           resources:
-            limits:
-              cpu: 100m
             requests:
               cpu: 20m
               memory: 32Mi
@@ -170,8 +166,6 @@ spec:
           imagePullPolicy: IfNotPresent
           name: csi-attacher
           resources:
-            limits:
-              cpu: 100m
             requests:
               cpu: 20m
               memory: 32Mi
@@ -190,8 +184,6 @@ spec:
           imagePullPolicy: IfNotPresent
           name: csi-resizer
           resources:
-            limits:
-              cpu: 100m
             requests:
               cpu: 20m
               memory: 32Mi
@@ -216,7 +208,6 @@ spec:
           name: csi-cloudscale-plugin
           resources:
             limits:
-              cpu: 100m
               memory: 1Gi
             requests:
               cpu: 20m