Fixes for UKI without sd-boot, UKI with legacy installkernel, and rEFInd #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
from
721246a
to
34cfd7f
Compare
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
from
0be7bb9
to
9f32a14
Compare
On systems without systemd-boot we might still install and boot UKIs, with e.g. refind, or directly from firmware. On such systems the 'loader' directory (bls type 1) won't be present. Instead we only have the ESP/EFI/Linux directory (bls type 2), which we still want to clean-up. Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
2 times, most recently
from
a93febd
to
ee5f25b
Compare
Nowa-Ammerlaan
changed the title
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
2 times, most recently
from
0b41b5f
to
85edf4c
Compare
|
@mgorny This is now ready I think. I added the fixes for rEFInd icon files here as well to avoid rebasing later. |
mgorny
requested changes
Apr 25, 2024
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
4 times, most recently
from
36d8754
to
e946e6f
Compare
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
from
f208bb1
to
b1db927
Compare
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
from
b1db927
to
6197857
Compare
Nowa-Ammerlaan
added a commit
to projg2/installkernel-gentoo
that referenced
this pull request
May 7, 2024
See-also: projg2/eclean-kernel#51 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
mgorny
requested changes
May 7, 2024
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
6 times, most recently
from
dc5f2bc
to
1a1a4f4
Compare
mgorny
reviewed
May 7, 2024
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
from
1a1a4f4
to
b90dd04
Compare
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
3 times, most recently
from
df128f5
to
2090440
Compare
mgorny
reviewed
May 8, 2024
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
2 times, most recently
from
07d64fc
to
8d15663
Compare
Closes: projg2#49 Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
this works around a bug in tox.ini where it does not take into account the dependencies of the package Signed-off-by: Andrew Ammerlaan <andrewammerlaan@gentoo.org>
Nowa-Ammerlaan
force-pushed
the
generalize-uki
branch
from
8d15663
to
a754019
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP/EFI/Linuxbut noESP/loaderdirectory. Extend ESP finding logic to also take into account this case.