Update add bind view cachestats #207
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: maxiaoyu <maxiaoyu@kuaishou.com>
SuperQ
reviewed
Apr 16, 2024
Comment on lines
+80
to
+83
| resolverCacheStats = prometheus.NewDesc( | ||
| prometheus.BuildFQName(namespace, resolver, "cache_stats"), | ||
| "Number of Cache Stats in Cache database.", | ||
| []string{"view", "stat"}, nil, |
There was a problem hiding this comment.
I'm not sure what "Cache Stats" are. Prometheus convention is that the metric name and help should be understandable by the end user without having to know what the underlying code implementation is.
Do you have a link to any upstream documentation about these values?
We typically don't just generically expose random values with "stat" labels. This provides for a poor user experience.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I use BIND DNS as a recursive DNS, I consider cache hits and miss to be important monitoring metrics, so I added information related to cachestats.