From f726405fecf7c89dcea83733c6245c3ad9d5bf63 Mon Sep 17 00:00:00 2001
From: Ben Kochie <superq@gmail.com>
Date: Mon, 20 Jan 2025 09:28:36 +0100
Subject: [PATCH] [ci] Update codeowners script (#5212)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-authored-by: Jan-Otto Kröpke <github@jkroepke.de>
---
 .editorconfig                           |  5 +++++
 .github/CODEOWNERS                      | 14 +++++++-------
 .github/workflows/check-codeowners.yaml |  2 +-
 scripts/check-codeowners.sh             | 20 ++++++++++----------
 4 files changed, 23 insertions(+), 18 deletions(-)
 create mode 100644 .editorconfig

diff --git a/.editorconfig b/.editorconfig
new file mode 100644
index 000000000000..e38f1d3a1dcb
--- /dev/null
+++ b/.editorconfig
@@ -0,0 +1,5 @@
+root = true
+
+[*.sh]
+indent_style = space
+indent_size = 2
diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS
index f4d0b36c5bc8..74d440681e48 100644
--- a/.github/CODEOWNERS
+++ b/.github/CODEOWNERS
@@ -1,4 +1,4 @@
-# See https://github.com/scottrigby/prometheus-helm-charts/issues/12
+# See https://github.com/prometheus-community/helm-charts/issues/12
 # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
 # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
 
@@ -6,16 +6,15 @@
 # Unless a later match takes precedence, they will be requested for review when someone opens a pull request.
 * @prometheus-community/helm-charts-admins
 
-/.github/workflows/ @prometheus-community/helm-charts-admins @jkroepke @GMartinez-Sisti
-/renovate.json @prometheus-community/helm-charts-admins @jkroepke @GMartinez-Sisti
+/.github/workflows/ @prometheus-community/helm-charts-admins @GMartinez-Sisti
+/renovate.json @prometheus-community/helm-charts-admins @GMartinez-Sisti
 
-/charts/alertmanager/ @monotek @naseemkullah
 /charts/alertmanager-snmp-notifier/ @maxwo
+/charts/alertmanager/ @monotek @naseemkullah
 /charts/jiralert/ @jkroepke @zanhsieh
-/charts/kube-prometheus-stack/ @andrewgkew @gianrubio @gkarthiks @GMartinez-Sisti @jkroepke @QuentinBisson @scottrigby @Xtigyro
+/charts/kube-prometheus-stack/ @GMartinez-Sisti @QuentinBisson @Xtigyro @andrewgkew @gianrubio @gkarthiks @jkroepke @scottrigby
 /charts/kube-state-metrics/ @dotdc @mrueg @tariq1890
 /charts/prom-label-proxy/ @jkroepke
-/charts/prometheus/ @gianrubio @naseemkullah @Xtigyro @zanhsieh @zeritti
 /charts/prometheus-adapter/ @hectorj2f @mattiasgees @steven-sheehy
 /charts/prometheus-blackbox-exporter/ @desaintmartin @gianrubio @monotek @rsotnychenko
 /charts/prometheus-cloudwatch-exporter/ @asherf @gianrubio @torstenwalter
@@ -37,7 +36,7 @@
 /charts/prometheus-node-exporter/ @gianrubio @zanhsieh @zeritti
 /charts/prometheus-opencost-exporter/ @mattray
 /charts/prometheus-operator-admission-webhook/ @zeritti
-/charts/prometheus-operator-crds/ @dacamposol @desaintmartin @jkroepke @QuentinBisson
+/charts/prometheus-operator-crds/ @QuentinBisson @dacamposol @desaintmartin @jkroepke
 /charts/prometheus-pgbouncer-exporter/ @stewartshea @zeritti
 /charts/prometheus-pingdom-exporter/ @monotek @rpahli
 /charts/prometheus-pingmesh-exporter/ @dongjiang1989
@@ -54,3 +53,4 @@
 /charts/prometheus-to-sd/ @acondrat
 /charts/prometheus-windows-exporter/ @jkroepke
 /charts/prometheus-yet-another-cloudwatch-exporter/ @cristiangreco @thomaspeitz
+/charts/prometheus/ @Xtigyro @gianrubio @naseemkullah @zanhsieh @zeritti
diff --git a/.github/workflows/check-codeowners.yaml b/.github/workflows/check-codeowners.yaml
index fdac0877444a..65eff90f0324 100644
--- a/.github/workflows/check-codeowners.yaml
+++ b/.github/workflows/check-codeowners.yaml
@@ -13,7 +13,7 @@ jobs:
 
       - name: generate CODEOWNERS
         run: |
-          ./scripts/check-codeowners.sh > .github/CODEOWNERS
+          ./scripts/check-codeowners.sh | tee .github/CODEOWNERS
 
       - name: check CODEOWNERS for modifications
         run: |
diff --git a/scripts/check-codeowners.sh b/scripts/check-codeowners.sh
index e03c02a4d4d1..5e3bfb2151af 100755
--- a/scripts/check-codeowners.sh
+++ b/scripts/check-codeowners.sh
@@ -1,7 +1,10 @@
 #!/usr/bin/env bash
 
+# Make sure sort works predictably.
+export LC_ALL=C
+
 cat <<EOF
-# See https://github.com/scottrigby/prometheus-helm-charts/issues/12
+# See https://github.com/prometheus-community/helm-charts/issues/12
 # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners
 # https://docs.github.com/en/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax
 
@@ -9,15 +12,12 @@ cat <<EOF
 # Unless a later match takes precedence, they will be requested for review when someone opens a pull request.
 * @prometheus-community/helm-charts-admins
 
-/.github/workflows/ @prometheus-community/helm-charts-admins @jkroepke @GMartinez-Sisti
-/renovate.json @prometheus-community/helm-charts-admins @jkroepke @GMartinez-Sisti
+/.github/workflows/ @prometheus-community/helm-charts-admins @GMartinez-Sisti
+/renovate.json @prometheus-community/helm-charts-admins @GMartinez-Sisti
 
 EOF
 
-for DIR in $(ls -1 -d ./charts/*)
-do
-  FILE="$DIR/Chart.yaml"
-  DIR=$(echo $DIR | sed 's/^\.//')
-  MAINTAINERS=$(yq e '.maintainers.[].url' $FILE | sed 's!^https://github.com/!@!' | sort --ignore-case)
-  echo $DIR/ $MAINTAINERS
-done
+yq_script='"/charts/" + .name + "/ " + ([.maintainers[].url | sub("https://github.com/", "@")] | sort | join(" "))'
+
+yq e "${yq_script}" charts/*/Chart.yaml |
+  sort -t '/' -k 3