[alertmanager] Conditional volume mounting for configmap reload #4926
+3
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it
Optional volume mount when using config map reloader. Without this, the deployment will fail if you have
config.enabled
set to false since it can't find the volume.This error would show up in the event logs when adding the config reloader
With this change, you can then specify the volume mount if you are using a secret / etc using
configmapReload.extraVolumeMounts
and the service will deploy as expected.cc: @monotek @naseemkullah
Checklist
[prometheus-couchdb-exporter]
)