Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alertmanager] Conditional volume mounting for configmap reload #4926

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hemstreet
Copy link

@hemstreet hemstreet commented Oct 21, 2024

What this PR does / why we need it

Optional volume mount when using config map reloader. Without this, the deployment will fail if you have config.enabled set to false since it can't find the volume.

This error would show up in the event logs when adding the config reloader

create Pod alertmanager-2 in StatefulSet alertmanager failed error: Pod "alertmanager-2" is invalid: spec.containers[0].volumeMounts[0].name: Not found: "config"

With this change, you can then specify the volume mount if you are using a secret / etc using configmapReload.extraVolumeMounts and the service will deploy as expected.

cc: @monotek @naseemkullah

Checklist

  • DCO signed
  • Chart Version bumped
  • Title of the PR starts with chart name (e.g. [prometheus-couchdb-exporter])

Signed-off-by: Jon Hemstreet <jonhemstreet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant