[kube-prometheus-stack] Grafana operator integration #5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
Signed-off-by: Oleg Tsymbal <dzirg44@gmail.com>
dzirg44
requested review from
andrewgkew,
gianrubio,
gkarthiks,
GMartinez-Sisti,
jkroepke,
QuentinBisson,
scottrigby and
Xtigyro
as code owners
dzirg44
changed the title
jkroepke
reviewed
Jan 20, 2025
There was a problem hiding this comment.
Why we have GrafanaDashboard twice? One here and one in each file of dashboard-1.14
jkroepke
reviewed
Jan 20, 2025
| app.kubernetes.io/instance: grafana | ||
| app.kubernetes.io/name: grafana-operator | ||
| {{- end }} | ||
| datasource: |
There was a problem hiding this comment.
this config below datasource looks similar to https://github.com/prometheus-community/helm-charts/blob/main/charts/kube-prometheus-stack/templates/grafana/configmaps-datasources.yaml
can we move it an distinct template that the template can be shared for CRD, non CRD approach?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Grafana Operator Integration
This pr brings the integration with Grafana Operator, and in addition to configmaps creates CRD for Grafana (it should be installed independently)
it creates:
GrafanaDatasourcefrom the datasources (unfortunately we can't reuse configmaps)GrafanaDashboardresources from the configmapssync_grafana_dashboards.pyto generateGrafanaDashboarddynamicallyTested on my local Kubernetes cluster.
This is POC Pull Request, so if you already discussed it - sorry in advance.
Special notes for your reviewer
@andrewgkew @gianrubio @gkarthiks @GMartinez-Sisti @jkroepke @scottrigby @Xtigyro @QuentinBisson
Checklist
[prometheus-couchdb-exporter])