From 1c9c6943e8becf8b7365120c26d5d6db0101c7ed Mon Sep 17 00:00:00 2001 From: Piotr Dobrowolski Date: Sun, 14 Jul 2024 20:30:32 +0200 Subject: [PATCH] Add better error logging on smartctl exec failure We will now log a warning if smartctl path passed via command line is invalid. Signed-off-by: Piotr Dobrowolski --- readjson.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/readjson.go b/readjson.go index 234bc85..67efefb 100644 --- a/readjson.go +++ b/readjson.go @@ -85,6 +85,9 @@ func readSMARTctlDevices(logger log.Logger) gjson.Result { level.Warn(logger).Log("msg", "S.M.A.R.T. output reading error", "err", err) return gjson.Result{} } + } else if err != nil { + level.Warn(logger).Log("msg", "S.M.A.R.T. output reading error", "err", err) + return gjson.Result{} } return parseJSON(string(out)) }