Fixes issue #887: Sort histogram bounds before validation (#888)

Signed-off-by: Aleksandr Turchenko <aleksandr.turchenko@lightspeedhq.com>
prometheus · Nov 2, 2023 · c4dc833 · c4dc833
1 parent e9a0468
commit c4dc833
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/...bridge/src/main/java/io/prometheus/metrics/simpleclient/bridge/SimpleclientCollector.java b/...bridge/src/main/java/io/prometheus/metrics/simpleclient/bridge/SimpleclientCollector.java
@@ -288,8 +288,8 @@ private Unit convertUnit(Collector.MetricFamilySamples samples) {
 
     private ClassicHistogramBuckets makeBuckets(Map<Double, Long> cumulativeBuckets) {
         List<Double> upperBounds = new ArrayList<>(cumulativeBuckets.size());
-        Collections.sort(upperBounds);
         upperBounds.addAll(cumulativeBuckets.keySet());
+        Collections.sort(upperBounds);
         ClassicHistogramBuckets.Builder result = ClassicHistogramBuckets.builder();
         long previousCount = 0L;
         for (Double upperBound : upperBounds) {

diff --git a/...ge/src/test/java/io/prometheus/metrics/simpleclient/bridge/SimpleclientCollectorTest.java b/...ge/src/test/java/io/prometheus/metrics/simpleclient/bridge/SimpleclientCollectorTest.java
@@ -94,7 +94,7 @@ public void testHistogramComplete() throws IOException, InterruptedException {
                 .name("response_size_bytes")
                 .help("response size in Bytes")
                 .labelNames("status")
-                .buckets(64, 256)
+                .buckets(64, 256, 512.1)
                 .register(origRegistry);
         histogram.labels("200").observeWithExemplar(38, "trace_id", "1", "span_id", "2");
         histogram.labels("200").observeWithExemplar(127, "trace_id", "3", "span_id", "4");