Store and use archived filename in the bin directory #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of the remote_write_sender tests, use the archived filename Signed-off-by: Raphael Silva <rapphil@gmail.com>
|
@tomwilkie can you take a look into this pr? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of the remote_write_sender tests, use the archived filename to generate the filename of the binaries stored in
binand used for the tests.The reason why we need this is because it will provide more stable filenames since the name will not rely on the name of the published artifact.
Before this change the files stored in bin after a run of
go test --tags=compliance -run "TestRemoteWrite/.+" -vwere:After:
This will solve #97