Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for running agent only mode #283

Merged
merged 2 commits into from
Dec 25, 2023
Merged

Conversation

n-marton
Copy link
Contributor

in agent only mode, the exporter exposes information only about services registered on the local agent

this is useful for cases when one uses consul with acl system enabled, so some services might not make to catalog because the agent doesn't have permission to register them

it would be nice to have metrics from both sides for comparison

…es registered only on the local agent

Signed-off-by: n-marton <marton@natko.hu>
pkg/exporter/consul_exporter.go Outdated Show resolved Hide resolved
Co-authored-by: Ben Kochie <superq@gmail.com>
Signed-off-by: n-marton <marton@natko.hu>
@n-marton n-marton requested a review from SuperQ December 13, 2023 13:04
Copy link
Member

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SuperQ SuperQ changed the title add flag for running agent only mode Add flag for running agent only mode Dec 25, 2023
@SuperQ SuperQ merged commit 5f70718 into prometheus:master Dec 25, 2023
7 checks passed
SuperQ added a commit that referenced this pull request Dec 25, 2023
* [FEATURE] Add service meta metrics #264
* [FEATURE] Add flag for running agent only mode #283

Signed-off-by: SuperQ <superq@gmail.com>
@SuperQ SuperQ mentioned this pull request Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants