Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated function usages #350

Open
gharlan opened this issue Aug 5, 2015 · 7 comments
Open

Deprecated function usages #350

gharlan opened this issue Aug 5, 2015 · 7 comments

Comments

@gharlan
Copy link
Contributor

gharlan commented Aug 5, 2015

There are some deprecated (since SF 2.7) function usages which should be fixed.

Examples:

screenshot 2015-08-05 16 46 02

@gharlan
Copy link
Contributor Author

gharlan commented Aug 6, 2015

Would it be ok to bump the symfony min version from 2.5 to 2.7?
2.5 is dead, and 2.6 is in "security fixes only" mode and will be dead from 01/2016.

The fixes would be simpler.

@havvg
Copy link
Member

havvg commented Aug 6, 2015

Is there any technical reason for the required changes (didn't have a look at them by now) to raise the dependency version?

I'm against it, as there are probably applications out there, which do not require 2.7. Which is fine, if they don't have needs for it. So if this bundle does not require 2.7, we are not in charge or responsibility to raise the dependency for any application using this bundle.

@angelk
Copy link

angelk commented Dec 2, 2015

There are symfony 2.8, in witch forms do no work.
There is symfony 3.0, witch can't be installed because of composer requirements.

@havvg havvg added this to the 1.5 - Symfony 2.8 LTS support milestone Jan 22, 2016
@havvg
Copy link
Member

havvg commented Jan 22, 2016

I'm on the current move:

There is a new branch 1.5 which raises the dependency to Symfony 2.8, which is the current LTS. I gave it a lot of thoughts, and this step is fine, we commit on an LTS and this will be easier to support on a new branch, while leaving the old branches. The old ones will only receive an update on the incompatibility of their respective Symfony versions.

The second branch (not created yet) will be 1.6, which will be Symfony 3.0 compatible, but 2.8 incompatible.

@havvg
Copy link
Member

havvg commented Jan 23, 2016

The former Propel1 bridge of the symfony package has been merged. In case you are still up to it, the 1.5 branch is ready for the changes.

The distributed phpunit.xml.dist disables the deprecation errors, you have to change the error level.

@gharlan
Copy link
Contributor Author

gharlan commented Feb 10, 2016

@havvg I forgot to mention in my initial post that I'm talking about the propel 2.x version.
What should be the min symfony version for 2.x branch?

@havvg
Copy link
Member

havvg commented Feb 11, 2016

@gharlan I would suggest ^2.8|^3.0, being ready for upcoming 3.4 LTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants