Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve deprecated function usages #351

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Resolve deprecated function usages #351

merged 1 commit into from
Dec 3, 2015

Conversation

gharlan
Copy link
Contributor

@gharlan gharlan commented Aug 6, 2015

@gharlan gharlan force-pushed the resolve-deprecated-function-usages branch from 77127cc to cffdb63 Compare August 6, 2015 17:15
@gharlan
Copy link
Contributor Author

gharlan commented Aug 6, 2015

This was the easy part.

It's more difficult to resolve these messages:

  • The Symfony\Component\Form\Extension\Core\ChoiceList\ObjectChoiceList class is deprecated since version 2.7 and will be removed in 3.0. Use Symfony\Component\Form\ChoiceList\ArrayChoiceList instead.
  • The "choice_list" option is deprecated since version 2.7 and will be removed in 3.0. Use "choice_loader" instead.

@gharlan gharlan force-pushed the resolve-deprecated-function-usages branch from cffdb63 to a457e69 Compare September 3, 2015 14:58
@gharlan
Copy link
Contributor Author

gharlan commented Dec 1, 2015

Maybe this can be merged as-is?
The missing parts could be done in another PR (by someone other or by me when I have more time).

@gharlan gharlan changed the title [WIP] Resolve deprecated function usages Resolve deprecated function usages Dec 1, 2015
@gharlan gharlan force-pushed the resolve-deprecated-function-usages branch from a457e69 to 002d4d9 Compare December 3, 2015 09:44
@gharlan
Copy link
Contributor Author

gharlan commented Dec 3, 2015

(rebased)

havvg added a commit that referenced this pull request Dec 3, 2015
@havvg
Merge pull request #351 from gharlan/resolve-deprecated-function-usages
754580d 
Resolve deprecated function usages
@havvg havvg merged commit 754580d into propelorm:2.0 Dec 3, 2015
@havvg
Copy link
Member

havvg commented Dec 3, 2015

Thanks!

@gharlan gharlan deleted the resolve-deprecated-function-usages branch December 3, 2015 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gharlan @havvg