-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add a way to display search suggestions #78
base: custom-list
Are you sure you want to change the base?
Conversation
@nesium Why wouldn't this already work? We do not intercept Tab events 🤔 |
Is that default NSTextView behavior? Have you tried it? |
Yes it is, as long as you check the System Preferences > Keyboard > Shortcuts > "Use keyboard navigation to move focus between controls" checkbox. I don't know why it's not the default, but it's there. |
There are too many commits cluttering the PR, let me rebase this correctly. |
d5409e3
to
1df05ce
Compare
There are still many added files, but I will remove most of them before marking this PR as ready. |
Here is a recording of the attached window: Screen.Recording.2022-07-20.at.11.58.31.movWhat you should see:
I think that's all I wanted t note 🤔 |
09aef53
to
9a12d2c
Compare
This is nice 🙂 Screen.Recording.2022-07-26.at.15.52.43.movNo more height computation, no more manual clipping, no more background color… |
9a12d2c
to
694e3ad
Compare
3b99807
to
a1b5d61
Compare
48ace8a
to
ca026e6
Compare
870403e
to
dc70ee3
Compare
ca026e6
to
e495275
Compare
This reverts commit 70ee5fd. - feat: WIP Add `TCATextView` - chore: Add `autoSuggest` higher-order `Reducer` - feat: Introduce `AutoSuggestList` - feat: Introduce `.attachedWindow` - chore: Allow using the attached window corner radius from everywhere - feat: Use `CustomList` to avoid height computation
e495275
to
2235156
Compare
It was initially in #76, but I separated the two features.
Makefile
@nesium's TODO-list proposition (modified a bit):
1. TCA-driven TextView + Reducer
#119
2. AutoSuggest reducer and environment
2.1 AutoSuggest list
CustomList
#853. SwiftUI window
4. ContactSuggestionField (or actually just a reducer)
vCloses the window when escape is pressed