Remove dependency on deprecated oldest-supported-numpy #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
References: * https://github.com/scipy/oldest-supported-numpy * https://numpy.org/doc/2.1/dev/depending_on_numpy.html#build-time-dependency Signed-off-by: Mathias Burger <mathias.burger@gmail.com>
asofter
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Description
Remove dependency on the deprecated oldest-supported-numpy. They state that it is not necessary to use that package anymore since numpy 1.25. To my understanding, the dependency would only be required as build-time-dependency and not as a runtime dependency.
References:
Issue reference
The dependency breaks resolution for artifacts requiring a higher version of numpy:
File "/opt/python/versions/3.11.10/lib/python3.11/site-packages/resolvelib/resolvers.py", line 318, in _backjump raise ResolutionImpossible(causes) resolvelib.resolvers.ResolutionImpossible: [RequirementInformation(requirement=<Requirement('numpy==1.26.4; python_version >= "3.11" and python_version < "3.12"')>, parent=None), ..., RequirementInformation(requirement=<Requirement('numpy==1.23.2; python_version == "3.11" and platform_python_implementation != "PyPy"')>, parent=Candidate(name='oldest-supported-numpy', version=<Version('2022.11.19')>, extras=set()))]Checklist