Tilezen tags [#303] #309
Tilezen tags [#303] #309
Conversation
* remove min_admin_level, replace with kind_detail * add default boundaries sort_rank
add sort_rank to water labels
| @@ -24,7 +24,6 @@ public String name() { | |||
| public void processNe(SourceFeature sf, FeatureCollector features) { | |||
| var sourceLayer = sf.getSourceLayer(); | |||
| var kind = ""; | |||
| var kindDetail = ""; | |||
There was a problem hiding this comment.
kindDetail was implemented in v3 as a forward compatible change to Tilezen 1.9 schema. It's not necessary to remove it v4, although you can if you want. Natural Earth has a lot of extra fidelity that wasn't captured before... but for rendering probably just kind and the disputed boolean are sufficient for most basic maps.
| @@ -192,7 +176,6 @@ public void processOsm(SourceFeature sf, FeatureCollector features) { | |||
| switch (minAdminLevel.getAsInt()) { | |||
| case 2 -> { | |||
| kind = "country"; | |||
| kindDetail = "2"; | |||
There was a problem hiding this comment.
Be wary of removing kindDetail here as kind alone doesn't capture some of the per country variance –– right now Protomaps v3 and v4 would push more boundaries features from OSM into tiles than Tilezen v1.9 schema, and the kindDetail would provide a way to filter those out in the style. The better fix would be to be more selective at tile cut, of course.
| } // end highway= | ||
|
|
||
| // non-highway features | ||
| // todo: exclude railway stations, levels |
There was a problem hiding this comment.
This is important, there were several Tilezen versions where we didn't have that filtering and the rendering was borked.
|
No description provided.